[ML] use reset feature API for internal cluster ML tests#71836
Merged
benwtrent merged 3 commits intoelastic:masterfrom Apr 19, 2021
Merged
[ML] use reset feature API for internal cluster ML tests#71836benwtrent merged 3 commits intoelastic:masterfrom
benwtrent merged 3 commits intoelastic:masterfrom
Conversation
benwtrent
added
>test
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Member
Author
|
run elasticsearch-ci/bwc |
Member
Author
|
@elasticmachine update branch |
droberts195
approved these changes
Apr 19, 2021
| // automatically recreated. | ||
| assertAcked(client().admin().indices().prepareDelete(nonAnnotationMlIndices).get()); | ||
| } | ||
| client().execute(ResetFeatureStateAction.INSTANCE, new ResetFeatureStateRequest()).actionGet(); |
There was a problem hiding this comment.
I think you should also delete the comment on lines 91-94, as this cleanup is now doing more than what that comment says. It will mean that in the future it will be possible to use this base class for tests that might leave jobs running when they complete.
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 19, 2021
Replaces the bespoke ML cleanup code with the feature reset API for internal cluster tests
benwtrent
added a commit
that referenced
this pull request
Apr 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the bespoke ML cleanup code with the feature reset API for internal cluster tests